-
Notifications
You must be signed in to change notification settings - Fork 140
Add regex example to advanced routing #4073
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4073 +/- ##
==========================================
- Coverage 86.53% 86.51% -0.02%
==========================================
Files 131 131
Lines 17796 17796
Branches 74 74
==========================================
- Hits 15399 15397 -2
- Misses 2197 2199 +2
Partials 200 200 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@ciarams87 would it be better to add this new HTTPRoute to |
562de83 to
e507532
Compare
e507532 to
100bd86
Compare
100bd86 to
94773df
Compare
Proposed changes
Problem: The advanced routing guide in the documentation is being updated to include an example for regex path type so we need to update our examples to reflect this
Solution: Add the new regex route yaml corresponding to the guide
Closes #3946
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.